Lock ops based on computed key rather than LLB digest #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejholly
force-pushed
the
mh/next-source-op-caching
branch
from
9ed8778
to
6e287a4
Compare
mikejholly
force-pushed
the
mh/next-source-op-caching
branch
from
6e287a4
to
d144e62
Compare
alexcb
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues with how source ops are run. They need to be run once per build & kept in a "mutable" state to reuse content checksum data across builds. See comments for more details.
Earthly tests: https://github.com/earthly/earthly/actions/runs/9196103317